feat(web): created agents deploy the bundled entry with Myra's tools (CL-8578) - #927
Merged
Merged
Conversation
Adds workflowId to buildMyraWorkflow's test input ahead of making it required, and switches the renderer tests off renderWorkflowSourceTree ahead of its removal.
…(CL-8578) buildMyraWorkflow now takes a required workflowId, so the same bundle Myra deploys can build any agent's definition. Created agents push that bundled tree instead of a JSON-only one, so they carry the mail and posix tool factories Myra carries instead of none. Drops renderWorkflowSourceTree now that nothing renders the JSON-only shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolFactories: [], so they launched with no tools at all.agents/myra/src/index.ts'sbuildMyraWorkflow) is generalized to build any agent's definition, keyed by a requiredworkflowId, so created agents can share it.Changes
MyraWorkflowInputgains a requiredworkflowId; Myra's own deploy passesASSISTANT_WORKFLOW_ID.pushAgentSourceinapps/web/src/agent-deploy.tsnow renders the same bundled source tree Myra deploys (renderBundledWorkflowSourceTree), using the agent's slug asworkflowId, its system prompt, trigger address, and the offering's declared sources.buildAgentDefinitionJsonstill produces the JSON projection written beside the entry.renderWorkflowSourceTreenow that nothing renders the JSON-only shape; its tests were switched to exerciserenderBundledWorkflowSourceTreeinstead, which covers the same tree-shape guarantees.buildAgentDefinitionJson's projection and the bundle's build input agree on id, prompt, and trigger address.Testing
bun test agents/myra/src/definition.test.ts apps/web/src/agent-deploy.test.ts packages/workflows/src/source.test.ts packages/workflows/src/validate-push.test.tsbun run check