fix(web): the Deploy card explains a rejected package (CL-8579) - #931
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployablePackagenow distinguishes a valid package, a named rejection, and "not a package attempt at all," so the person always sees why a Deploy card didn't appear.Changes
deployablePackage/deployablePackageFromBody/resolveMessagePackagereturn aPackageOutcome: a parsed package,{ reason }naming the missing or invalid field in plain words, ornullwhen neither contract file is present.namenow comes fromdefinition.json, falling back topackage.json'snamewhendefinition.jsonomits it;package.jsonis parsed with arktype too, and unknown fields anywhere are ignored rather than fatal.message-attachments.tsxrenders a small rejection card in the Deploy card's visual family, naming the reason, with no Deploy button.Testing
bun test apps/web/src/chat/deployable-package.test.tsbun run check(typecheck, lint, fmt, unit tests) from the repo root