fix(web): shell polish for failed-run insight, palette, tour, and settings (CL-8459) - #938
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /workflows/runs/:runId/eventsroute.SKILL.mdcontent over the asset's git remote, so there was no stale "not readable yet" disclosure to keep or remove.Changes
apps/web/src/insights-api.ts: arktype schema for the run-events response, a path helper, andrunFailureMessagereadingRunFailed/StepFailedevent bodies.apps/web/src/pages/insights-page.tsx:InsightsRunDetailfetches and renders the failure message plus a togglable event list for a failed run, viauseQuery-backeduseAPIQuery.apps/web/src/command-palette-actions.ts(+ test): removed thego-insightsaction command.apps/web/src/shell/first-run-tour.tsx: dropped the composer step.apps/web/src/settings/{account-section,index,strings}.ts: removedAgentGeneralSection.apps/web/src/pages/tools-page.tsx: added the read-only note above the packages table.Testing
bun run typecheckbun test ./src/command-palette-actions.test.ts ./src/pages/insights-page.test.ts ./src/pages/insights-page-render.test.tsx ./src/settingsbun run check(full monorepo typecheck/lint/fmt/test)agent-browser; the app sits behind a sign-in wall with no available local credentials, so pages beyond the login screen could not be exercised this session.