fix(web): chats are titled by the agent's display name and land without a modal (CL-8439) - #939
Merged
Merged
Conversation
Covers the new priority in chatTitle: agent name first, opening turn subject/body only when the agent can't be resolved.
…ut a modal (CL-8439) The chat heading, sidebar row, and composer placeholder all derived from mail metadata that could surface a run address; title them by the agent's display name instead, falling back to the opening turn's subject only when the agent itself can't be resolved. Landing on `/` could also drop the first-run tour's overlay over the chat it just redirected onto — the tour now only opens on an explicit "Take the tour" command, never automatically.
TheGreatAxios
force-pushed
the
cl-8439-agent-display-name
branch
from
September 18, 2026 19:26
555b727 to
95954a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/, where it could overlay the chat the person was just redirected onto; it now opens only via an explicit "Take the tour" command.Changes
apps/web/src/chat/threads-api.ts:chatTitlenow prioritizes the agent's display name, falling back to the opening turn's subject/body only when the agent can't be resolved; exported for testing.apps/web/src/pages/chat-thread-page.tsx: the chat heading useschat.agentNamedirectly.apps/web/src/shell/first-run-tour-store.ts(new): a small external store gating the tour's open state.apps/web/src/shell/first-run-tour.tsx: reads open state from the store instead of auto-starting on mount.apps/web/src/command-palette-actions.ts: adds a "Take the tour" command that opens the tour explicitly.Testing
bun test src/chat/threads-api.test.tsbun run check(typecheck, lint, fmt, test) — all greenhttp://localhost:5173required a signed-in session and no test credentials were available.