fix(web): a scheduled run reports to the person who deployed it (CL-8580) - #940
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cron@<domain>) has no mailbox and the agent's reply is silently dropped by the hub.Changes
apps/web/src/agent-deploy.ts:scheduleAgentRunresolves the deploying person's mailbox address (<refId>@<tenantDomain>, same shapethreads-api.tsbuilds a person participant's address from) via the existing session probe, and passes it into a newbuildScheduledRunBodyhelper that asks the agent to mail its result there (as a single-itemtolist) with a short subject. Falls back to a bare reply instruction if the session probe comes back empty — never fails the deploy over it.Testing
bun test apps/web/src/agent-deploy.test.tsbun run check