fix(web): Ollama model validation, credential edit and delete, composer and polling fixes (CL-8464) - #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/tags, offering a select of pulled models instead of free text.useMutationover the stock DELETE route, and a credential row can now be edited (name, description, and a base URL / model pair for a local-style credential) through the stock PATCH route.Changes
apps/web/src/onboarding/ollama-tags.ts(+test): browser-side fetch/parse of Ollama's native/api/tags.apps/web/src/onboarding/provider-connect-step.tsx: model field is now aSelectpopulated from live tags, gated on the model actually being present.apps/web/src/settings/credentials-api.ts,credentials-section.tsx,strings.ts:updateCredential(PATCH), an Edit dialog, and create/update/delete converted touseMutation.apps/web/src/chat/composer.tsx:event.repeatguard on Enter/Shift+Enter.apps/web/src/pages/chat-thread-page.tsx,apps/web/src/pages/workbench-page.tsx: approvalsrefetchIntervalscoped to "an agent is starting"; workbench page's inbox subscription now also invalidates the approvals key.Testing
bun run check(typecheck, lint, fmt, full test suite) passes.bun test src/settings/credentials-api.test.ts,bun test src/onboarding/ollama-tags.test.ts.