chore(web): comments say why, never what; long ones move to docs (CL-8378) - #944
Merged
Merged
Conversation
…t-value/tests (CL-8378)
…kill-version-author (CL-8378)
…ct/approval-actions (CL-8378)
…l-packages (CL-8378)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/src(excludingsettings/inference/**andonboarding/**, owned by another in-flight branch) was reviewed: deleted if it narrated what the code does, shortened to its why (1-3 lines) if it held one, or moved into a shortdocs/*.mdsection with a one-line pointer left in code when it held real rationale worth preserving.bun run typecheckafter every batch.Changes
docs/chat-wire-contract.md,docs/chat-mail-threading.md,docs/settings-sections.md,docs/routines-scheduling.md,docs/test-toast-mock.md,docs/myra-definition-json.md,docs/insights-native-runs.md,docs/auth-dither-background.md.Testing
bun run typecheck(repo root) — passesbun run lint— passes (pre-existing unrelated warnings inapps/sidecar)bun run fmt:check— passesbun run test(repo root, includesapps/web's build +bun test ./src) — 266 + 621 pass, 0 fail