Fix DNS watcher from clearing known endpoints on lookup failure#7698
Open
Wassup789 wants to merge 3 commits into
Open
Fix DNS watcher from clearing known endpoints on lookup failure#7698Wassup789 wants to merge 3 commits into
Wassup789 wants to merge 3 commits into
Conversation
Signed-off-by: Wilson La <wilsnlaa@amazon.com>
Signed-off-by: Wilson La <wilsnlaa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Components like the querier and query-frontend use the DNSWatcher to handle resolution of addresses. When DNS lookups fail (due to an issue on the DNS server, for instance), the resolved address set is set to nil, which sends a Delete for every previously known address.
This PR changes the DNSWatcher to retain all previously known addresses during DNS resolution failures, to prevent queriers (for instance) from clearing all known DNS records.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags