Skip to content

Assert store-gateway path in compression test#7701

Open
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:fix-store-gateway-compression-test-path
Open

Assert store-gateway path in compression test#7701
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:fix-store-gateway-compression-test-path

Conversation

@Rohithmatham12

Copy link
Copy Markdown

What this changes

  • Waits until the store-gateway has loaded the shipped block, not only until a bucket sync has happened.
  • After querying the shipped series, asserts that the querier recorded a /gatewaypb.StoreGateway/Series client request.
  • This makes the store-gateway compression subtest prove it exercised the -querier.store-gateway-client.grpc-compression path.

Fixes #7583.

Testing

  • GOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test -tags requires_docker,integration,integration_grpc ./integration -run TestGRPCCompression -count=0

Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestGRPCCompression doesn't guarantee queries hit the store-gateway path the compression flag applies to

1 participant