Skip to content

Strengthen stream push signing mismatch test#7702

Open
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:strengthen-stream-push-signature-test
Open

Strengthen stream push signing mismatch test#7702
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:strengthen-stream-push-signature-test

Conversation

@Rohithmatham12

Copy link
Copy Markdown

What this changes

  • Strengthens the mismatched signing-key stream-push integration test.
  • Requires the HTTP push call itself to complete successfully before checking the rejection status.
  • Ensures every mismatched-key push asserts a non-200 response instead of skipping the assertion when client.Push returns an error.

Fixes #7580.

Testing

  • GOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test -tags requires_docker,integration ./integration -run TestIngesterStreamPushConnectionWithMismatchedSigningKey -count=0

Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream-push security test in integration/ingester_stream_push_test.go is effectively a no-op when signing fails

1 participant