Skip to content

Clarify old sample validation flag scope#7703

Open
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:clarify-old-sample-validation-flags
Open

Clarify old sample validation flag scope#7703
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:clarify-old-sample-validation-flags

Conversation

@Rohithmatham12

Copy link
Copy Markdown

What this changes

  • Clarifies that validation.reject-old-samples and validation.reject-old-samples.max-age are enforced by the distributor before samples are forwarded.
  • Clarifies that late samples rejected by ingester TSDB because they are older than the head minimum time are controlled by ingester.out-of-order-time-window.
  • Updates both the flag help text and configuration docs so operators see the same guidance in CLI and docs.

Fixes #6220.

Testing

  • GOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test ./pkg/util/validation -run 'TestLimits_Validate|TestLimits_ValidateQueryLimits' -count=1
  • git diff --check

Note: a broader local go test ./pkg/util/validation run hit an unrelated segmentation fault in the existing TestValidateNativeHistogram path before this change was involved.

Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
@dosubot dosubot Bot added component/distributor component/ingester type/chore Something that needs to be done; not a bug or a feature labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/distributor component/ingester size/S type/chore Something that needs to be done; not a bug or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is argument -validation.reject-old-samples.max-age valid for distributor or ingester or both?

1 participant