Conversation
"The test suite runs on all three on every push" is wrong in the way that matters: tests.yml restricts its push trigger to main, so a push to develop runs nothing at all. The v4.2.0 release pull request was the first time CI had seen 24 of its own commits, and it failed two of them on both Unix legs. Nothing replaces it. It was reassurance in an install section, and the badge row and the workflow itself already answer the question for anyone asking it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only, a two-line deletion.
switch_claude_account.ps1is byte-identical tov4.2.0, so this carries no version bump, no changelog entry and no release, for the same reason as #22: tagging it would publish an asset nobody's copy differs from.What changed
Removed "The test suite runs on all three on every push." from Installation → Requisite.
The claim is false.
.github/workflows/tests.ymlrestricts itspushtrigger tomain, so a push todevelopruns nothing; CI fires on a pull request, on a push tomain, and onworkflow_dispatch. The v4.2.0 release pull request demonstrated the gap rather than hypothesizing it: it was the first run over 24 commits, and it failed two tests on both Unix legs that no Windows run could have caught.Nothing replaces the line. It was reassurance sitting in an install section, and the badge row and the workflow file already answer the question for anyone who is asking it.
Shortcomings
Feedback I want
developto thepushbranches would make the original claim true and close the gap that let 24 untested commits reach a release pull request. I did not do it here because it is a CI change wearing a documentation change's clothes, and it belongs in its own pull request with its own argument about runner minutes.What is not done
tests.yml. See above.