bugfix: Add the needed javac options to metals - #331
Merged
Conversation
We need these to access the java compiler internals.
Collaborator
Author
|
@alexarchambault did anything change to the credentials? Getting 401 in https://github.com/coursier/apps/actions/runs/33496569818/job/99820574523 |
Member
Collaborator
Author
|
Ach ok, though I guess users will all have to update coursier now to get any new apps, right? |
Member
|
I guess so, although that won't be too long hopefully. In the mean time, it should be possible to explicitly pass the upcoming (as soon as the CI will have generated the first version of it) listing file URL to "cs install". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need these to access the java compiler internals.
Should fix scalameta/metals#8144 and scalameta/metals#8812