Conversation
cathaysia
force-pushed
the
feat/remote-dockerignore
branch
from
September 7, 2026 02:20
3a54724 to
08e215c
Compare
Add DockerIgnore support using the glob crate to filter files and directories when copying project and mounted volumes to remote container data volumes. Also integrate with Fingerprint to ensure persistent volume incremental updates respect .dockerignore.
cathaysia
force-pushed
the
feat/remote-dockerignore
branch
from
September 7, 2026 02:52
08e215c to
f27c491
Compare
Contributor
Author
|
Hi, could someone please review this? |
Emilgardis
requested changes
Sep 9, 2026
Replace escaped \n string literals with multi-line raw strings so .dockerignore test content is readable at a glance.
Podman prefers `.containerignore` with a fallback to `.dockerignore`, while Docker only reads `.dockerignore`. Warn when the chosen file does not match the running engine.
cathaysia
force-pushed
the
feat/remote-dockerignore
branch
from
September 10, 2026 03:49
a27d2eb to
4eaee6b
Compare
Replace recursive copy_dir_with_rel and Fingerprint::_read_dir with a VecDeque queue so deeply nested contexts cannot blow the stack, while preserving skip/dockerignore pruning and depth-aware callbacks.
Contributor
Author
Considering that most of the traversal work involves pruning, using walkedir may not be as beneficial as we thought. I changed the recursion to iteration to avoid potential stack overflow issues. |
Contributor
Author
|
Is there anything else here that needs to be modified? |
Member
|
No, just need to have a look at the changes once more and then can merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
.dockerignorefiles when copying project and mounted volumes to remote container data volumes.Changes
docker_ignoremodule for.dockerignoreparsing and pattern matching based on theglobcrate:#), blank lines, and UTF-8 BOM.!) in sequential order./suffix).**) patterns usingglob::MatchOptions { require_literal_separator: true, .. }following Docker / Mobypatternmatcherspecifications..dockerignorefiltering into directory copying (copy_dir_with_relandcopy_files_filtered) inremote.rs, skipping ignored files and directories during traversal..dockerignorefiltering intoFingerprintscanning so persistent volume incremental sync respects ignore rules.close #1800