Wire explore page - #109
Conversation
- Category and condition chips in FilterView animate color on selection using a spring transition; no xmark shown. - RangeSlider now renders a full-opacity filled track segment between the two handles. Co-authored-by: Cursor <cursoragent@cursor.com>
Float the toolbar over the scroll view with ultraThinMaterial so the glass effect is actually visible against scrolling content. Reduce toolbar bottom padding (26→14) and profile top padding (25→12) to remove excess whitespace between the nav bar and the profile card. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the floating ZStack toolbar with a LazyVStack layout so the header scrolls away naturally. Use pinnedViews: [.sectionHeaders] to keep the listings/reviews tab bar stuck at the top once the profile header scrolls off screen. Also removes the now-unnecessary nested inner ScrollViews. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- Replace 3-tab bar (Home/Messages/Profile) with 5-tab frosted glass pill (Home/Explore/Sell/Messages/Profile) - Selected tab shows a black capsule with icon + animated label; unselected shows icon only - Add SellView with New Listing and New Request action cards - Remove floating ExpandableAddButton from HomeView (superseded by Sell tab) - Fix profile tab index reference in ProductDetailsView (2 → 4) - Explore tab is a placeholder pending future implementation Co-authored-by: Cursor <cursoragent@cursor.com>
- Switch VStack to ZStack so the tab bar overlays content, giving the ultraThinMaterial glass something to render behind it - Add safeAreaInset placeholder so scroll content isn't permanently hidden beneath the floating pill - Replace black selected capsule with the resell purple→pink→orange gradient Co-authored-by: Cursor <cursoragent@cursor.com>
- Layer a white tint over ultraThinMaterial so the bar reads as a consistent light frosted pill on both light and dark backgrounds - Add a hairline border and stronger shadow for elevation - Darken inactive tab icons/labels via new tabBarInactive color Co-authored-by: Cursor <cursoragent@cursor.com>
- Lower selected tab gradient opacity so it reads as a gentler pastel - Switch Messages/Profile to paperplane and person.crop.circle icons - Remove leftover ExpandableAddButton from ProfileView (superseded by Sell tab) Co-authored-by: Cursor <cursoragent@cursor.com>
Adds skeleton Daily Picks/Trending/Events, reusable CategoriesView, and Saved/Recently Viewed collages backed by local view history. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| Circle() | ||
| .frame(width: 80, height: 80) | ||
| .foregroundStyle((filter.color?.opacity(0.5)) ?? Constants.Colors.filterGray) | ||
| // Circle() |
There was a problem hiding this comment.
this should be removed instead of commenting
|
Let's not create such big prs from now on. I'm not sure where to even start reviewing this |
i did this all over the summer and i was communicating with Andrew throughout-- i don't think it's a good use of your time to thoroughly review unless you want to. thats also why i omitted a description. Stacking it or having ppl review over the summer also felt silly lol |
if you or andrew are uncomfortable merging such big changes w/o reviewing thoroughly then it should not be merged bc reviewing all of this manually is probably not a good use of time unless you are bored. my plan was to demo my changes and let ppl use it on testflight and ship when/ if ppl are comfortable but if ppl disagree then that's okay |
|
Nah this pr is tuff |
aight bro you guys can do whatever you guys want |
Having a big change is totally okay. The main reason we want to make smaller, incremental changes was so that reviewers and anyone referencing the work later can clearly follow what changed in each section. That's why I personally think Uplift was easy to work with when I took over. I also don’t mind having multiple PRs if that makes things easier to review and reference. I know both you and Andrew are eager to make changes, and I’m all for that. I’m just encouraging you guys to also do the less exciting, harder part of making sure those changes are easy for other people to understand and maintain. It’s not only the two of you looking at this right now other people may need to understand, review, or build on this work later. Breaking the changes up with even with a few lines of description makes that a lot easier. Resell is an official pod, so ideally this codebase should last beyond just the people working on it right now. |
|
But lowkey since Andrew REALLY wants Resell to be a flagship app lets just push this pr 😛 |
|
do not merge this i will revoke your write privileges charles what is this PR bro |
|
Thats valid too late now tho lmaooooooo - To Jiwon |
|
Charles showed me a demo video of this, and seems to work well so I think we just keep the changes. Doesn't break anything major from initial video, but I'll fix any bugs that appear by end of sem. |
|
yo put that demo video on the pr at least why you guys gatekeeping 😭 |
|
|
@AndrewG828 @JiwonJeong414 @stef-rivera If u guys wanna hop on call i can defend and clarify things. I think that makes more sense than this lol |
4 participants
BIG OLE Push
This is actually a lot less than i thought lol what