ONECOND-2416: bump jsrsasign 8.0.12 -> 11.1.1 - #1039
Merged
Merged
Conversation
Remediate 2 critical Dependabot alerts in d3sw/conductor: - GHSA-27fj-mc8w-j9wg (RSA signature validation on malleable message; < 10.2.0) - GHSA-5jx8-q4cp-rhh6 (DSA private key recovery via biased nonce; < 11.1.1) ^11.1.1 (>= 11.1.1) clears both ranges. jsrsasign is used only in ui/src/core/AuthClient.js for KJUR.b64toutf8(); verified that API is present and round-trips a base64 JWT payload on 11.1.1. Previous: ^8.0.12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Updates the UI’s jsrsasign dependency to remediate two critical Dependabot advisories affecting older versions, while keeping the usage surface limited to JWT payload base64→UTF8 decoding in the UI code.
Changes:
- Bump
jsrsasignfrom^8.0.12to^11.1.1inui/package.jsonto move beyond both vulnerable ranges.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blam28
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates 2 critical Dependabot alerts on
jsrsasignind3sw/conductor(ui/package.json).Bumps
jsrsasign^8.0.12 → ^11.1.1.< 10.2.0>= 7.0.0, < 11.1.1^11.1.1(>= 11.1.1) is the lowest target that clears both ranges — 10.2.0 alone would leave the second alert open.Change
Impact / verification
jsrsasignis a direct dependency, used in a single place:KJUR.b64toutf8()inui/src/core/AuthClient.js(base64->UTF8 decode of a JWT payload). No crypto/signature APIs are used.jsrsasign@11.1.1thatb64toutf8is present and round-trips a base64 JWT payload — the 8->11 major bump is a safe drop-in for this usage.ui/, sopackage.jsonfully drives resolution; the vulnerable version leaves the dependency graph.Rollback
Revert the single-line change (previous:
^8.0.12).Jira: https://bydeluxe.atlassian.net/browse/ONECOND-2416
🤖 Generated with Claude Code