ci: pin golangci-lint instead of inheriting latest - #29
Conversation
The lint gate ran `version: latest`, which means it can go red on a day nobody touched the code — a golangci-lint release that enables a linter by default, or tightens an existing one, is enough. It then reads as "your PR broke lint" to whoever is next, and costs them the bisect to find out it was drift. "Merge on green" only works if green is a property of the repo rather than of the calendar. Pinned to v2.12.2, which is what `latest` resolved to for the run that took this repo to 0 findings — so the pin is the version actually verified, not a guess. Policy in the comment for the next reader: bump the pin when we choose a new linter, never inherit one. Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
The lint gate ran
version: latest. That means it can go red on a day nobody touched the code — a golangci-lint release that enables a linter by default, or tightens an existing one, is enough to do it. It surfaces as "your PR broke lint" to whoever is next, and costs them a bisect to discover it was drift rather than their change."Merge on green" only means something if green is a property of this repo rather than of the calendar.
Pinned to
v2.12.2— which is whatlatestresolved to for the run that took this repo to 0 findings (upstream's current release, and the same version the local runs used). So the pin is the version that was actually verified, not a guess, and this change moves nothing about what the linter reports today.The comment carries the policy for the next reader, so the pin doesn't get mistaken for staleness: bump it when we choose a new linter, never inherit one.
Same change is coming for
dAppCore/mcponce #24 lands there.🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io