test: take the suite from 187 failures to 25

[Snider]

Stacked on #13 (base is fix/make-package-installable, so the diff shows only this work). Retarget to main once #13 merges.

187 failed / 127 passed → 25 failed / 289 passed, across 315 tests.

Getting the suite to reach the code

fix	failures cleared
load migrations in defineDatabaseMigrations	125
alias trait accessors to public on the test stand-in	28
RefreshDatabase on the four class-style tests	5

Migrations. 180 failures were a missing database and nothing else — 113 on workspaces, 27 on mcp_tool_metrics, 24 on mcp_tool_versions, 15 on users, 1 on mcp_tool_combinations. Boot.php publishes the package's migrations for a host app to run rather than loading them, and php-tenant does the same, so under Testbench there was no schema at all.

Protected accessors. WorkspaceContextSecurityTest builds a stand-in over the RequiresWorkspaceContext trait, whose accessors are protected — correct for a real tool, unreachable from a test. Nineteen assertions died on "Call to protected method … from scope" without ever exercising the behaviour. The stand-in now aliases them via use RequiresWorkspaceContext { getWorkspaceId as public; … }, which exposes them for assertion without widening the trait itself.

RefreshDatabase. Pest's uses(RefreshDatabase::class)->in() only reaches Pest-style files, so four class-style tests under src/Mcp/Tests never picked it up, migrated and rolled back for real, and failed the rollback on "no such table: migrations".

Three production defects the running suite exposed

Laravel\Mcp\Request has no input(). Its accessor is get(). Nineteen calls across five tools — QueryDatabase, DescribeTable, CreateCoupon, UpgradePlan, ListInvoices — would have thrown BadMethodCallException on first use. Every one of those tools was broken. The two middleware that also call input() are deliberately untouched: they take Illuminate\Http\Request, where it's correct. This was a per-file check of which Request each imports, not a blanket rename. None used dot-notation keys, so get() is an exact swap.

Laravel\Mcp\Response has no getContent() — that's the Illuminate API. It exposes content(), returning a Content that implements __toString().

ToolAnalyticsService::flushToolCombinations() could never record a pair for the first time. It called updateOrInsert() with DB::raw('occurrence_count + 1') as the value — right on the update path, invalid on the insert path where it becomes insert into … (occurrence_count) values (occurrence_count + 1), a column reference inside a VALUES clause. The insert threw, so the follow-up query written to repair exactly that case never ran. Also now uses whereNull for a null workspace: = null is never true in SQL, so a global pair matched nothing and would be re-inserted on every flush.

What remains

25 failures, a long tail of individual causes rather than a shared one. The clearest is McpToolVersion::orderByVersion, which sorts using MySQL-only SUBSTRING_INDEX and therefore cannot execute on sqlite at all — that one needs a portability decision (driver-aware SQL, a sortable stored version key, or ordering in PHP) rather than a patch, so it is left for a follow-up.

🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4952cce1-e7ed-4dbd-b842-41954cbc9857

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}