Skip to content

fix: build warnings in analyzer test project#480

Merged
samtrion merged 1 commit into
mainfrom
fix/analyzer-tests-build-warnings
Jul 22, 2026
Merged

fix: build warnings in analyzer test project#480
samtrion merged 1 commit into
mainfrom
fix/analyzer-tests-build-warnings

Conversation

@samtrion

Copy link
Copy Markdown
Contributor

Summary

  • Replace deprecated HasCount() assertion with Count()
  • Add StringComparer.Ordinal to Dictionary<string, string?> instances (MA0002)
  • Add ConfigureAwait(false) to awaited calls in test code (MA0004)

Test plan

  • dotnet build reports 0 warnings, 0 errors
  • dotnet test tests/NetEvolve.Defaults.Analyzer.Tests.Unit — 55/55 passed

Replace deprecated HasCount() with Count(), add ordinal string
comparers to Dictionary instances, and configure awaits to not
capture the synchronization context.
@samtrion
samtrion requested a review from a team as a code owner July 22, 2026 19:53
@samtrion
samtrion requested review from benwirren and removed request for a team July 22, 2026 19:53
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • state:ready for merge

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2c3558e-aaef-47c8-9ddb-d9984589af57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@samtrion samtrion changed the title Fix build warnings in analyzer test project fix: build warnings in analyzer test project Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8b300e6) to head (7efac9b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           16        16           
  Branches         1         1           
=========================================
  Hits            16        16           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samtrion
samtrion merged commit a1f55ca into main Jul 22, 2026
14 checks passed
@samtrion
samtrion deleted the fix/analyzer-tests-build-warnings branch July 22, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant