DAOS-19381 rebuild: skip -1 target in layout_find_diff - #18754
Open
liuxuezhao wants to merge 1 commit into
Open
Conversation
|
Ticket title is 'Aurora engine crash - determine_valid_spares() Assertion' |
wangshilong
previously approved these changes
Jul 30, 2026
When no spare target available, the new_tgt possibly be -1 in POST_REBUILD layout, skip that shard's remap to avoid such assertion - placement/jump_map.c:207 layout_find_diff() Assertion 'rc == 1' failed (pool_map_find_target(jmap->jmp_map.pl_poolmap, new_tgt, &new_pot) failed). Add some debug log about rebuild target list. Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com> Co-authored-by: Wang Shilong <shilong.wang@hpe.com>
liuxuezhao
force-pushed
the
lxz/new_tgt_skip_28
branch
from
August 2, 2026 07:55
54aa53e to
aaad2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no spare target available, the new_tgt possibly be -1 in POST_REBUILD layout, skip that shard's remap to avoid such assertion - placement/jump_map.c:207 layout_find_diff() Assertion 'rc == 1' failed (pool_map_find_target(jmap->jmp_map.pl_poolmap, new_tgt, &new_pot) failed).
Add some debug log about rebuild target list.
Steps for the author:
After all prior steps are complete: