ci: remove Codecov upload job - #409
Merged
Merged
Conversation
The `coverage` job in ci.yml ran pytest with --cov flags solely to upload coverage.xml to Codecov via `codecov/codecov-action@v4`. Both `fail_ci_if_error: false` and `continue-on-error: true` meant the check always showed green regardless of whether the upload actually landed. No `codecov.yml` config exists in the repo, so the upload uses defaults if it reaches Codecov at all. Nothing else in the tree consumes coverage.xml -- no follow-up jobs, no scripts, no doc references. Removing the whole job rather than just the upload step avoids leaving a coverage run without a purpose. `build`'s `needs: [test, lint]` is unaffected -- it never depended on coverage. Verified no other Codecov references anywhere in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
coveragejob from.github/workflows/ci.yml. The job's sole purpose was uploadingcoverage.xmlto Codecov viacodecov/codecov-action@v4, and bothfail_ci_if_error: falseandcontinue-on-error: truemeant the check always showed green regardless of whether the upload actually landed.Why
codecov.ymlconfig in the repo -- if uploads were reaching Codecov, they used defaults.coverage.xml(no follow-up jobs, no scripts, no doc references). The coverage run existed only to feed the upload step.What changed
Deletes the entire
coverage:job (36 lines).build'sneeds: [test, lint]is unaffected -- it never depended on coverage. Verified no other Codecov references anywhere in the repo.Not in scope
uv run pytest --cov=packages/darnit/src --cov=packages/darnit-baseline/src. If we want it in CI later, add it back with a real consumer.