docs: record the third-party notices - #71
Merged
Merged
Conversation
The repo had no notices file, and one entry made that a real gap rather than a tidiness one: the Michroma wordmark is compiled into every shipped binary by juce_add_binary_data, so its OFL notice is owed to whoever runs the app, not just to whoever reads the source. Recorded with it: minimp3 (CC0, pinned by commit), JUCE, nlohmann/json as test-tier only, and the Linux system libraries we link but do not ship. Two things stated because a reader could reasonably wonder: the embedded font is the unmodified original, so none of the OFL's modification questions arise; and rc5cat is cited throughout as a source of format KNOWLEDGE, which is not copyrightable subject matter — no code of it is here.
The sentence promising a record of third-party dependencies was dropped when no such file existed. It exists now, so the promise comes back pointing at it, the way the sibling repos' policy files point at theirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo had no notices file. One entry makes that a real gap rather than a tidiness one: the Michroma wordmark is compiled into every shipped binary by
juce_add_binary_data, so its OFL notice is owed to whoever runs the app, not just to whoever reads the source.Recorded with it, ordered by how close each travels to the user: minimp3 (CC0-1.0, pinned by commit — the one bundled mp3 decoder, because stock JUCE cannot read mp3 on Linux and the platform codecs leave the LAME delay/padding at the loop seam), JUCE 8.0.14 under our AGPLv3 option, nlohmann/json marked explicitly as test-tier-only since the app never links it, and libudev / alsa-lib / DiskArbitration / IOKit as platform libraries we link but do not ship.
Two things are stated because a reader could reasonably wonder:
Michroma-Regular.ttfbyte for byte — no subsetting, no re-instancing — so nothing here is a Modified Version and the OFL questions that come with modification do not arise.Second commit puts back the sentence in
CONTRIBUTING.mdthat promised such a record — it was dropped when no file existed, and now points at one.No code, build or licence change.