fix(qt): restore transparent background for all scroll areas - #7632
fix(qt): restore transparent background for all scroll areas#7632PastaPastaPasta wants to merge 1 commit into
Conversation
cebae5a narrowed the global .QScrollArea rule to only the masternode wizard's mnWizardScroll, so every other scroll area (e.g. the send entries area on the Send and CoinJoin screens) lost its transparent background and painted the default darker gray panel. Restore the global rule and keep the wizard-specific child-widget rules it actually needed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
✅ Final review complete — no blockers (commit 6c2f717) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe stylesheet now applies transparent backgrounds and no borders to Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized GUI styling change restores transparent, borderless scroll areas while preserving the masternode wizard styling; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Codex/Sol only (Phase 2 disabled)
At exact head 6c2f717, the focused stylesheet diff restores the pre-regression global .QScrollArea transparency and border rule while preserving the masternode wizard’s child-widget rules; no correctness, compatibility, history, or scope issues were found. The visual validation described in the PR is appropriate for this CSS-only fix, and the change is ready for approval.
Source: reviewer backend model gpt-5.6-sol (Codex general and commit-history lanes); final verifier backend model gpt-5.6-sol; openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and is not counted as independent reviewer evidence.
Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed),gpt-5.6-sol— dash-core-commit-history (completed) - Verifier:
gpt-5.6-sol— verifier - Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
- Secondary pass: disabled (
temporary_phase2_sonnet_disable)
Issue being fixed or feature implemented
cebae5a (#7618) narrowed the global
.QScrollAreatransparency rule ingeneral.cssto only the masternode wizard'sQScrollArea#mnWizardScroll. As a result every other scroll area in the GUI lost its transparent background and zero border, and now paints Qt's default palette panel with a visible frame — most noticeably the scroll area hosting the send entries on the Send and CoinJoin screens.What was done?
Restored the global rule
and kept only the wizard-specific child rules that #7618 actually needed (
QScrollArea#mnWizardScroll > QWidgetand... > QWidget > QWidget). The wizard's scroll areas are plainQScrollAreainstances, so the global rule already covers the scroll area itself; the retained child rules keep the wizard's inner page widgets transparent, so the masternode wizard is unaffected by this fix. No new colors are introduced, so theupdate-css-files.pycolor inventories are unchanged.How Has This Been Tested?
Captured before/after screenshots on macOS (dark theme). Both runs use the same prebuilt
dash-qtbinary (built from 297c15b, the tip of #7618) on fresh, isolated regtest datadirs with an identically created wallet, identical window size, and CSS loaded from disk via-custom-css-dir— "before" usessrc/qt/res/cssat develop head 7be28f8, "after" uses this PR's head. The only variable between the two runs is the CSS directory.In the "before" images the entries area sits in a distinct bordered panel (the default
QScrollAreaframe plus palette fill that appear once the rule is gone); in the "after" images it blends into the page background again. The Send tab shows the same regression and fix (before / after). How dark the default panel fill renders depends on the platform palette — on the reporting machine it was considerably darker than in these captures — but the spurious frame and fill are gone either way once the rule is restored.Breaking Changes
None. GUI-only CSS change; the masternode wizard styling introduced in #7618 is preserved.
Checklist: