Skip to content

refactor(key-wallet)!: unify mnemonic parsing on one auto-detecting path - #981

Open
PastaPastaPasta wants to merge 1 commit into
devfrom
fix/non-english-mnemonic-ffi
Open

refactor(key-wallet)!: unify mnemonic parsing on one auto-detecting path#981
PastaPastaPasta wants to merge 1 commit into
devfrom
fix/non-english-mnemonic-ffi

refactor(key-wallet)!: unify mnemonic parsing on one auto-detecting path

571e882
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2026 in 0s

76.91% (-0.01%) compared to b66db39

View this Pull Request on Codecov

76.91% (-0.01%) compared to b66db39

Details

Codecov Report

❌ Patch coverage is 89.77273% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.91%. Comparing base (b66db39) to head (571e882).

Files with missing lines Patch % Lines
key-wallet-ffi/src/account_derivation.rs 37.50% 5 Missing ⚠️
key-wallet/src/account/derivation.rs 0.00% 2 Missing ⚠️
key-wallet-ffi/src/mnemonic.rs 50.00% 1 Missing ⚠️
key-wallet/src/mnemonic.rs 98.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #981      +/-   ##
==========================================
- Coverage   76.91%   76.91%   -0.01%     
==========================================
  Files         329      329              
  Lines       82897    82859      -38     
==========================================
- Hits        63757    63727      -30     
+ Misses      19140    19132       -8     
Files with missing lines Coverage Δ
key-wallet-ffi/src/wallet.rs 17.99% <100.00%> (+3.97%) ⬆️
key-wallet-manager/src/accessors.rs 60.35% <100.00%> (ø)
key-wallet-manager/src/lib.rs 73.47% <100.00%> (ø)
key-wallet/src/account/account_collection_test.rs 100.00% <100.00%> (ø)
key-wallet/src/account/mod.rs 62.41% <100.00%> (-0.38%) ⬇️
key-wallet/src/derivation.rs 73.15% <100.00%> (-0.70%) ⬇️
key-wallet/src/managed_account/address_pool.rs 79.45% <100.00%> (-0.06%) ⬇️
key-wallet/src/wallet/backup.rs 100.00% <100.00%> (ø)
key-wallet/src/wallet/mod.rs 95.58% <100.00%> (-0.08%) ⬇️
key-wallet-ffi/src/mnemonic.rs 29.13% <50.00%> (-17.33%) ⬇️
... and 3 more

... and 4 files with indirect coverage changes