Skip to content

Initial attempt at fixing ability to read TGA DTA .txt file#1900

Open
OMWalmsley wants to merge 6 commits into
datalab-org:mainfrom
OMWalmsley:OMWalmsley/TGA-parsing-fix-datablock
Open

Initial attempt at fixing ability to read TGA DTA .txt file#1900
OMWalmsley wants to merge 6 commits into
datalab-org:mainfrom
OMWalmsley:OMWalmsley/TGA-parsing-fix-datablock

Conversation

@OMWalmsley

Copy link
Copy Markdown

This PR attempts to solve parsing mp2028_281122_LNO+C.txt file.
Done by:

  • Creating new TGA parser specifically for the .txt file.
  • Writing tests for this new parser, that use the example file
  • Integrating into the TGA datablock.
    • Allowing multifile selection for this TGA datablock.
    • Allowing partial pressures to be plotted from a .asc file with the temperature from the .txt file to also be plotted.
      • Current approach assumes that the time points from the respective files start from the same point but might not be the same length (as given in the example files) (see sub issue Aligning Timestamps on .asc and .txt #1899).
    • Allows the .txt DTA file to be plotted solely
  • Fixing a bokeh issue where it fails to update the second plot line on a selectable_axes_plot graph.

Resolves issue #1897

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.77953% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.65%. Comparing base (91cbeb5) to head (5d7a9d7).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/tga/blocks.py 38.23% 42 Missing ⚠️
pydatalab/src/pydatalab/apps/tga/parsers.py 92.59% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   79.99%   79.65%   -0.35%     
==========================================
  Files          83       83              
  Lines        7493     7593     +100     
==========================================
+ Hits         5994     6048      +54     
- Misses       1499     1545      +46     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/tga/__init__.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/bokeh_plots.py 81.40% <100.00%> (+0.05%) ⬆️
pydatalab/src/pydatalab/apps/tga/parsers.py 92.47% <92.59%> (-1.53%) ⬇️
pydatalab/src/pydatalab/apps/tga/blocks.py 59.25% <38.23%> (-36.90%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OMWalmsley
OMWalmsley force-pushed the OMWalmsley/TGA-parsing-fix-datablock branch from 7bd91db to 4b3b04a Compare July 8, 2026 13:22
@OMWalmsley
OMWalmsley force-pushed the OMWalmsley/TGA-parsing-fix-datablock branch from 4b3b04a to cf57a6f Compare July 20, 2026 14:14
@OMWalmsley
OMWalmsley marked this pull request as ready for review July 20, 2026 14:43
@OMWalmsley
OMWalmsley requested a review from ml-evs July 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant