Skip to content

Item graph optimisations#1933

Open
ml-evs wants to merge 7 commits into
mainfrom
ml-evs/item-graph-fixes
Open

Item graph optimisations#1933
ml-evs wants to merge 7 commits into
mainfrom
ml-evs/item-graph-fixes

Conversation

@ml-evs

@ml-evs ml-evs commented Jul 19, 2026

Copy link
Copy Markdown
Member

Closes #1932 by:

  • making sure blocks are excluded from the graph layout computation
  • setting a iteration limit for elk layouts
  • better teardown of stale graph components and ensuring graph is deferred to after block loading

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.99%. Comparing base (91cbeb5) to head (3e41e96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          83       83           
  Lines        7493     7493           
=======================================
  Hits         5994     5994           
  Misses       1499     1499           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypress Bot commented Jul 19, 2026

Copy link
Copy Markdown

datalab    Run #5207

Run Properties:  status check passed Passed #5207  •  git commit 6e2289c6fd ℹ️: Merge 3e41e96e00007426ba225fa45fc94450c163d4f4 into 91cbeb520b7d6c4b3322f3ce759d...
Project datalab
Branch Review ml-evs/item-graph-fixes
Run status status check passed Passed #5207
Run duration 20m 37s
Commit git commit 6e2289c6fd ℹ️: Merge 3e41e96e00007426ba225fa45fc94450c163d4f4 into 91cbeb520b7d6c4b3322f3ce759d...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 548
View all changes introduced in this branch ↗︎

@ml-evs
ml-evs force-pushed the ml-evs/item-graph-fixes branch from f3818af to 7362d44 Compare July 19, 2026 14:25
@ml-evs
ml-evs force-pushed the ml-evs/item-graph-fixes branch from 7362d44 to 3e41e96 Compare July 20, 2026 13:15
@ml-evs
ml-evs requested a review from be-smith July 20, 2026 13:17
@ml-evs
ml-evs marked this pull request as ready for review July 20, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item graph layout can be slow for multiply-connected items with blocks

1 participant