Phase J: fail-closed secret-safe trace retention - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
RealDone now inspects every newly closed Playwright trace before linking it from automatic-scan or contract/MCP evidence. Secret-bearing, invalid, oversized, and over-expanded ZIPs are deleted fail-closed; reports retain only additive value-free suppression metadata. Exact checks include generated sensitive fields, contract
secretEnv, and opaque cookies/tokens from granted Playwright storage state.Observable gates
secret-detectedmetadata onlysecretEnvand auth-state role contracts: verification evidence remains valid, unsafe traces absentpnpm check: 142 passed, 2 expected service-dependent skipsFresh external qualification
Fingerprint
0b39d542…is backed by fresh SHA-256-bound TodoMVC, Actual Budget, Conduit SQLite, Conduit PostgreSQL 17 + Supabase Data API, PostgreSQL create/update/delete cleanup, Pocket Ledger Level 7, and a new Codex MCP baseline → RD901 → repair cycle. Validator result: 5/5 cases, 9/9 capabilities, RG14 clean. Merging those inputs with the six hosted candidate attestations passed all 15 gates locally; GitHub run30199694271is the required signed rerun.