Skip to content

feat: require hosted Codex review before merge - #64

Merged
davidahmann merged 11 commits into
mainfrom
codex/hosted-review-gate
Sep 21, 2026
Merged

davidahmann merged 11 commits into
mainfrom
codex/hosted-review-gate

Conversation

@davidahmann

Copy link
Copy Markdown
Owner

Problem

Mill could accept a draft PR after local review without requiring GitHub Codex to finish reviewing the exact latest head. Installation and first-use guidance also carried more detail than a newcomer needed.

Change

  • add an opt-in github_codex_required review policy with the real GitHub Codex bot identity
  • split draft readiness from final merge approval and bind post-readiness completion, feedback, exact head, and provider revision evidence
  • re-read provider feedback around completion and reject malformed, ambiguous, stale, or changing summaries
  • recheck hosted review evidence during final merge and post-merge closure
  • keep P2/P3 advisory under the repository's p0_p1 policy
  • shorten the README around install, inspect, approve, and reviewed draft delivery
  • document the review policy, repository settings, architecture, approvals, and 0.9.0 release
  • simplify local installation to an exact dev dependency plus npx --no-install millctl

Validation

  • npm run check
  • node dist/cli.js --json --cwd . audit
  • exact-candidate local maintainer review: ready, no P0/P1 findings
  • 54 test files and 569 tests pass
  • packed 0.9.0 package canaries pass

Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
@davidahmann
davidahmann force-pushed the codex/hosted-review-gate branch from 5b8a255 to 1e32b64 Compare September 21, 2026 23:39
@davidahmann

Copy link
Copy Markdown
Owner Author

@codex review

@davidahmann
davidahmann merged commit 3009a7f into main Sep 21, 2026
6 checks passed
@davidahmann
davidahmann deleted the codex/hosted-review-gate branch September 21, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant