fix: make scoped reviewer schema compatible with Codex - #67
Merged
Merged
Conversation
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
Owner
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mill 0.10.0 can verify a candidate with repository review checklists, then fail before review starts because Codex rejects the generated strict output schema. The nested checklist field is optional in that schema, and its path regex uses unsupported lookaround.
This change requires the field only when the frozen scope contains checklists and leaves path validation to Mill's existing local parser and exact-scope comparison. It covers both checklist and no-checklist scopes, bumps the package and documentation pin to 0.10.1, and adds the source release note.
Validation:
MILL_GIT_PATH=/opt/homebrew/bin/git npm run check; exact-head native maintainer review passed with zero findings (bcfcbffff6b97eebbbe4a0b204805812bf3f92c8). The previously rejected schema was reproduced against the installed Codex CLI, and the corrected schema was accepted.