fix: accept timestamped GitHub Codex review summaries - #68
Merged
Merged
Conversation
Signed-off-by: David Ahmann <46606159+davidahmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Codex now includes a
<relative-time>element afterCompletedandRunningin its PR review summary. Mill 0.10.1 treated the completed summary on Telryn PR #32 as invalid, leaving an otherwise verified and locally reviewed T-022 candidate unable to pass the hosted-review merge gate.This patch accepts only the observed timestamped forms when the UTC datetime and displayed timestamp match. It preserves the earlier bare forms and rejects mismatches and extra text. The regression test reproduces the current GitHub summary and failed on 0.10.1 before this fix. Version and README pins advance to 0.10.2 with a source release note.
Validation: full
npm run checkpassed twice; exact-head local maintainer review of3280a5439c0d9de33ecb98cab0d15d0da1f256b6passed with zero findings. Telryn PR #32 remains unmerged until this control fix is qualified and repinned.