Add CheckAll field to run multiple subchecks per round - #144
Open
thatliuser wants to merge 12 commits into
Open
thatliuser wants to merge 12 commits into
thatliuser wants to merge 12 commits into
Conversation
Owner
|
Could this be extracted to a shared interface that has this pattern? For example FTP and SSH have similar behaviors |
thatliuser
force-pushed
the
apply-checkall
branch
7 times, most recently
from
May 10, 2026 02:43
a227b05 to
480ee87
Compare
thatliuser
changed the title
web made a helper func for some reason instead of a closure
other impls do this so make it more consistent
With CheckAll, all commands run in the same shell and share one stdout buffer, so a later command could pass on output printed by an earlier one. Track buffer offsets per command and only inspect the new output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyxWdJuxxHaDuv9mbnoqxP
thatliuser
force-pushed
the
apply-checkall
branch
from
October 2, 2026 05:28
2b893a0 to
4248f0a
Compare
Instead of tracking buffer offsets in one shared shell, open a fresh session + shell per command on the existing connection so each command's output is fully isolated. Pulls the shell setup out into openShell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyxWdJuxxHaDuv9mbnoqxP
Service.Run stops reading the response channel once the timeout fires, so a check that finishes late blocked forever on the unbuffered send. Buffer it so the goroutine can always send and exit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyxWdJuxxHaDuv9mbnoqxP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VyxWdJuxxHaDuv9mbnoqxP
Contributor
|
This doesn't sound right calling these subchecks. It should be something like RunAll like RunAllRecords or entries or targets. If we want to keep check we could say like CheckAllRecords, but mostly check is used as a noun here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows the engine to run all subchecks of a service in a single round. imagine the following scenario:
this disincentivises blue teams from addressing a downed service which is only up due to luck.