Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 72.39% 72.57% +0.17%
==========================================
Files 53 53
Lines 3746 3770 +24
==========================================
+ Hits 2712 2736 +24
Misses 1034 1034
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #358
Description
Adds per-flag targeting in
warn_error_options. This allows users to silence (or error on) specific event instances via<event_name>:<flag_name>without affecting all event change warnings. From the motivating example from the issue this means being able to config:Notes on implementation:
discriminator()(defined onBaseEvent) if more specific targeting is useful for that event classWarnErrorOptionsV2can support anyClassName:discriminatorin the futureBehaviorChangeEventimplements discriminator() to return flag_nameBehaviorChangeEventstill targets all behavior-change events (backwards compatible)Local Testing n Validation
I have a dbt-core sandbox locally that uses the dbt-databricks adapter. I overrode the dbt-commons dependency in the uv virtual environment and pointed it to my local dev branch and ran manual tests:
Both tests show and confirm expected behavior!
Related user reports:
Checklist
changie newto create a changelog entryNOTE: This PR was created with AI-assistance (Cursor)