snd_commands.h wrong default define + both music+sfx issue

[GreenSnakeLinux]

Hello,

In the sample: 16-sound-music
snd_commands.h contain the define _SND_CMD_BASE_GENERATED with the value 4 but it should be 8
it works because in main.c you redefine it with a value of 8
The file contain 8 defaults commands in snd_commands_info.h
It should take it into account

Anyway I manage to play a sfx or a music with a lot of struggle, my rom.mk was the one from sample 1 (GAMEROM=puzzledp)
and i must change it to: GAMEROM=lastbld2 or GAMEROM=fatfury2
I have same result with both. I'm not sure to understand why, is puzzledp a game with no sound and no music ?

Now I want to play both sfx and music at same time, it is possible with a sfx using adpcm_b and music using also adpcm_b ?
or music must be in .fur format ? if yes how to convert .wav/.mp3 into .fur format ?
Currently if I play a sfx, the music stop. And in snd_commands.h my files are both detected as sfx: #define SND_NB_FX (2)

thanks for your help

[dciabrin]

Hello,

In the sample: 16-sound-music snd_commands.h contain the define _SND_CMD_BASE_GENERATED with the value 4 but it should be 8 it works because in main.c you redefine it with a value of 8 The file contain 8 defaults commands in snd_commands_info.h It should take it into account

Right, I didn't come up with a simple means to extract that information easily from your sound driver. Right now, the default is set to 4 because those 4 commands are reserved for the BIOS, and the rest is up to you. Example 16 exposes various actions from nullsound so I put them right after that. Granted, you could remove them if you don't need them (e.g. fade out).

Anyway, I get your point and I'm going to rework part of the driver to be more straightforward.

Anyway I manage to play a sfx or a music with a lot of struggle, my rom.mk was the one from sample 1 (GAMEROM=puzzledp) and i must change it to: GAMEROM=lastbld2 or GAMEROM=fatfury2 I have same result with both. I'm not sure to understand why, is puzzledp a game with no sound and no music ?

If I follow you, you swapped the default puzzledp rom.mk from example 01 for the fatfury2 rom.mk that came with this example. I think the difference is the VROMTEMPLATE variable that is - again - a detail that shouldn't be exposed in the makefile. I think you hit an issue with the way I'm trying to build the ADPCM sample ROM in a way that is as generic as possible, which is very confusing.

Do not spend too much time here, I am going to push very shortly an update to ngdevkit, where you'll be able to name your own ROM and configure it in a (hopefully) simpler way.

Now I want to play both sfx and music at same time, it is possible with a sfx using adpcm_b and music using also adpcm_b ? or music must be in .fur format ?

The question is can SFX and music play ADPCM-B at the same time, the answer is no, the SFX channels that you target must not be used by the music that is being played. Both subsystems have their own state tracker.

Currently if I play a sfx, the music stop.

You can however play a sample in ADPCM-B, as this channel is not being used by a music.
If your music does not target ADPCM-B, then it's a bug in the driver.

Let me know which one is it.

And in snd_commands.h my files are both detected as sfx: #define SND_NB_FX (2)

In example 16, i get the right defines for music and sfx

#define SND_NB_MUSIC (1)
#define SND_NB_FX (1)

Can you maybe share you added your test music and sample? Maybe that's a bug in the way those file are parsed by the tools.

[GreenSnakeLinux]

Thanks for your reply, I have added you to my repo
Do you mean that I can play SFX to ADPCM-A and play music to ADPCM-B ?

thanks

[dciabrin]

Thanks for your reply, I have added you to my repo Do you mean that I can play SFX to ADPCM-A and play music to ADPCM-B ?

The way the sound driver works is:

• you play a music composed with furnace, and this usually uses FM channels, possibly SSG channels, 3 ADPCM-A channels, and the ADPCM-B channels. This is how the majority of games worked back in the days.
• this leaves 3 ADPCM-A channels untouched by the music, and those can be used to play SFX.

This is what example 16 does: you get an example music that uses 4 FM + 3 ADPCM-A + ADPCM-B. This leaves channel 4 in the example to play a laser sound.

Note that this is just a proposed split. Nothing in the driver prevents you from doing a music with 4 ADPCM-A channel, and use ADPCM-B to play SFX exclusively. The important part is to not target the same channels for both the music and the SFX.

[GreenSnakeLinux]

Ok I found out the issue, the file snd_commands.inc is wrongly generated
What I understand so far, the data loaded in ix register for ADPCM-A and ADPCM-B are not in same format, but the generation create ADPCM-A data format for ADPCM-B :

        .db     0x05 ; channel
        .db     0xda ; l/r output + volume
        .db     0x20 ; channel (bit)

instead of:

        .dw     0xcb6b                  ; delta-n
        .db     0xc0                    ; l/r output
        .db     0xff                    ; volume

It is the tag : adpcm_a / adpcm_b inside .yaml file that determine the data loaded in ix register ? My yaml file is good so far...