Skip to content

Keep every page of a document, so annotations land on the right one #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giovi321 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep every page of a document, so annotations land on the right one #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/storage/models/archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,15 @@ func ArchiveFromHashDoc(doc *HashDoc, rs RemoteStorage) (*exporter.MyArchive, er
}
}

// Every page the document declares gets an entry, whether or not anyone
// drew on it. The exporter takes a page's background from its position in
// this list, so leaving the untouched ones out moves every page after
// them: the nth page with ink ends up over the nth page of the document.
for _, p := range a.Content.Pages {
page := archive.Page{
Pagedata: "Blank",
}

if hash, ok := pageMap[p]; ok {
log.Debug("page ", hash)
reader, err := rs.GetReader(hash)
Expand All @@ -82,12 +90,10 @@ func ArchiveFromHashDoc(doc *HashDoc, rs RemoteStorage) (*exporter.MyArchive, er
return nil, err
}

page := archive.Page{
Data: rmpage,
Pagedata: "Blank",
}
a.Pages = append(a.Pages, page)
page.Data = rmpage
}

a.Pages = append(a.Pages, page)
}

return &a, nil
Expand Down