Offer Firefox permission recovery for USB screen sharing - #486
Closed
iibaranov-IG wants to merge 1 commit into
Closed
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
iibaranov-IG
marked this pull request as ready for review
September 14, 2026 17:27
Collaborator
|
No thanks slop bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox can omit the reMarkable USB interface from WebRTC ICE candidates until the rmfakecloud origin has media permission, leaving screen sharing on Wi-Fi with no explanation or recovery control.
Change
Add a Firefox-only USB recovery control that requests media permission, immediately releases every track, resets peer state for discovery retry, reports denial, and document why the permission is needed.
Fixes #485
Reproduction and acceptance
Open rmfakecloud over Wi-Fi in Firefox with a reMarkable connected over USB and no site media permission; the browser exposes its Wi-Fi candidate but omits local 10.11.99.5 while the tablet advertises 10.11.99.1.
The unchanged source-contract regression fails on the baseline and passes on the candidate; Firefox alone shows an explicit USB action, the action requests audio permission and stops all acquired tracks, denial is explained, documentation records the browser behavior, focused tests pass, and the complete UI production build succeeds.
BCL evidence
Run: https://github.com/iibaranov-IG/broadcast-control-lab/actions/runs/34874268293
Artifact:
rmfakecloud-485-evidenceBCL revision:
4b8a140a4b17f942e607bfc30b7944368728f899Tested baseline:
ddvk/rmfakecloud@1958bff18a530038d3916cba0168ad99a24220b4Candidate SHA-256:
387cfdc2db29d9aaf83ffc637906f873cd46fb05c5b22704b8c0aa2fd69fc113node --test ui/tests/firefox-usb-regression.test.mjs; exit: 1; log:upstream-2-baseline-red.lognode --test ui/tests/firefox-usb-regression.test.mjs; exit: 0; log:upstream-3-candidate-green.lognode ../../cases/rmfakecloud-485/upstream.mjs; exit: 0; log:upstream-4-candidate-suite.logOwner check
In Firefox, load rmfakecloud over Wi-Fi with the reMarkable connected over USB. Confirm 10.11.99.5 is absent before permission, click Enable Firefox USB access, grant microphone permission, confirm the capture indicator stops immediately, then verify about:webrtc selects 10.11.99.5 <-> 10.11.99.1 and screen sharing works.
BCL verifies browser detection, permission cleanup, the rendered source contract and the complete production UI build on Linux/Node 22. It cannot prove Firefox exposes 10.11.99.5 without a physical reMarkable USB connection and browser permission store.
Hardware verified: false. Full application verified: false.
The evidence artifact contains HARDWARE-CHECK.md and owner-result.json. Automated checks do not certify hardware.