Fix prod app image build: sqlx-cli 0.9.0 needs rustc 1.94, stage pins rust 1.93 - #748
Open
IvanTheGeek wants to merge 1 commit into
Open
Fix prod app image build: sqlx-cli 0.9.0 needs rustc 1.94, stage pins rust 1.93#748IvanTheGeek wants to merge 1 commit into
IvanTheGeek wants to merge 1 commit into
Conversation
The prod app image no longer builds: 'cargo install sqlx-cli' is unpinned,
and sqlx-cli 0.9.0 (published July 2026) requires rustc >= 1.94, while this
stage pins rust:1.93.0-trixie:
error: cannot install package `sqlx-cli 0.9.0`, it requires rustc
1.94.0 or newer, while the currently active rustc version is 1.93.0
Bump the build stage to rust:1.94.0-trixie (the same version
Dockerfile.dev already uses), and pin sqlx-cli to =0.8.6 — the version the
published talkyard-app images ship (checked v1.2026.003-f220a7d9f and
v1.2026.004-e80b4519d) — so the image contents stay deterministic instead
of tracking whatever crates.io serves next.
(Dockerfile.dev installs sqlx-cli unpinned too; its rust 1.94 still builds
0.9.0 today, but pinning it the same way might be worth doing for
dev/prod version consistency.)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
I, Ivan Rainbolt <talkyard@github-commits.ivanthegeek.com>, agree to the Contributor License Agreement, docs/CLA-v2.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prod app image build is currently broken:
cargo install sqlx-cliinimages/app/Dockerfile.prodis unpinned, and sqlx-cli 0.9.0 (published July 2026) requires rustc ≥ 1.94 — but the stage pinsrust:1.93.0-trixie:Fix:
rust:1.94.0-trixie(same as Dockerfile.dev), andsqlx-cli =0.8.6— the version the published talkyard-app images actually ship (checkedv1.2026.003-f220a7d9fandv1.2026.004-e80b4519dviasqlx --version) — so image contents stay deterministic instead of tracking whatever crates.io serves next.Verified: the rust stage builds, and a full prod app image built with this pin is file-for-file layout-identical to the published
v1.2026.003-f220a7d9fimage, with the samesqlx-cli 0.8.6.Note: Dockerfile.dev installs sqlx-cli unpinned too — its rust 1.94 happens to build 0.9.0 fine today, but you may want the same
=0.8.6pin there for dev/prod consistency (left out of this PR to keep the diff minimal).Found during the same Docker-only-build work as #747.
🤖 Generated with Claude Code