Skip to content

Refresh Chinese README for Electron launch - #2377

Closed
lg114 wants to merge 1 commit into
debpalash:mainfrom
lg114:docsfix
Closed

lg114 wants to merge 1 commit into
debpalash:mainfrom
lg114:docsfix

Conversation

@lg114

@lg114 lg114 commented Sep 28, 2026 •

Copy link
Copy Markdown

This commit updates README_CN.md to match the current Electron app positioning and install flow. It adds product positioning, badges, docs links, one-click install commands, source-run instructions, migration guidance for Tauri users, workspace and feature highlights, and refreshed sponsor/support sections.

Summary

README_CN.md had been left behind by 15 commits: its last change was 3f1f9bf9 (2026-09-16), while the English README was rewritten through d6348b56 (2026-09-26). This PR re-translates that delta so the Chinese README states the current Electron-only positioning, install paths, and documentation set. Documentation only — no runtime, build, dependency, or version changes.

Changes

  • Positioning & header: new tagline (voice design, transcription, 646 languages), Trendshift badge, CI / latest-release / AGPL-3.0 badges, and the website link in the nav row.
  • Feature overview: replaced the five-bullet "Create with VoiceStudio" list with the Create / Produce / Connect table, restoring the local API & MCP and optional remote-worker story; added the default engine (VoiceStudio, powered by k2-fsa/OmniVoice) and a link to docs/feature-catalog.md.
  • Install flow: added the macOS/Linux one-command installer (curl -fsSL https://voicestudio.sh/install | sh) with its --version / --main / --uninstall variants, prerequisites, and a link to docs/install/script.md.
  • Agent install: added the "Install with prompt" section pointing at docs/install/agent.md.
  • Source run: corrected the Electron preview instructions from cd electron && bun run dev to bun install && bun run setup:api && bun run dev. The old form skipped Python dependency preparation, so the shell could fail to start the backend; also added the bun run smoke-test note.
  • Tauri migration: added the callout that Electron is the only desktop and web UI and that 0.5.3 was the final Tauri release, linking docs/electron-migration.md.
  • Workspaces: wrapped the screenshot grid in a collapsible <details> block and added the extra desktop screenshot, matching the English README.
  • Docs & skills: named the two installable skills (voicestudio, voicestudio-maintainer).
  • Sponsors: renamed "Support VoiceStudio" to "赞助商" and added the docs/media/sponsor-slot.svg placement image.
  • Removed two elements the English README has already dropped: the <sub> caption under the demo GIF and the "still in active development" sentence.

Type

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • 🧪 Tests
  • 🔧 CI / Build
  • 🚀 Release prep

Testing

  • Link integrity: all 23 local markdown links and 6 <img src> targets in README_CN.md resolve to existing files; no dead links.
  • Structure parity with README.md: 11 headings in the same order; identical local-asset set (29 entries, both-direction set difference empty); 2 <details>, 1 <table>, 3 fenced code blocks.
  • Tests: pytest tests/test_no_hardcoded_cjk.py tests/test_voicestudio_branding.py → 10 passed. README_CN.md is allowlisted in the CJK check, and the branding test asserts on README.md, which is unchanged.
  • No runtime or version files touched, so the full suite was not run.

Checklist

  • I've tested this locally
  • I've updated relevant documentation (if applicable)
  • No local machine paths, logs, or personal env details in this PR
  • Maintained version files are in sync (if an owner-requested bump): root package.json, pyproject.toml, backend/core/version.py, and lockfiles — N/A, no version bump requested
  • If this PR changes runtime behavior, the regression fixture at tests/fixtures/omnivoice_data/ still loads green on the smoke-matrix CI job (macOS + Windows + Linux) — N/A, documentation-only change

The Chinese README now documents VoiceStudio’s Electron positioning, installation options, agent setup, migration guidance, and updated features. This aligns the documentation with the current app and install flow. No runtime changes are reported; test results and documentation-link validation are not independently confirmed.

This commit updates README_CN.md to match the current Electron app positioning and install flow. It adds product positioning, badges, docs links, one-click install commands, source-run instructions, migration guidance for Tauri users, workspace and feature highlights, and refreshed sponsor/support sections.
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Low risk] Updates Chinese README documentation for Electron release.

The documentation change appears safe to merge.

Summary

The Chinese README now describes the maintained Electron app, its installation and source-run paths, migration guidance, features, and support options.

Reviews (1) · Last reviewed commit: "Refresh Chinese README for Electron laun..."

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: debpalash/VoiceStudio/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5e61b84f-53b3-4a72-9ace-36184ecfd33e

📥 Commits

Reviewing files that changed from the base of the PR and between 08a1592 and 45fa229.

📒 Files selected for processing (1)
  • README_CN.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Chinese README updates VoiceStudio’s product overview, installation and development guidance, and support information. It describes Electron as the sole desktop app and Web UI, and identifies version 0.5.3 as the final Tauri release.

Changes

Chinese README

Layer / File(s) Summary
Project overview and gallery
README_CN.md
The README updates the product description, workflow overview, engine information, badges, and workspace gallery.
Installation and development instructions
README_CN.md
The README adds macOS and Linux installer commands and updates Electron installation, prerequisites, data-retention notes, and source-preview instructions.
Skills and support links
README_CN.md
The README distinguishes the audio-workflow skill from the repository-maintenance skill and updates sponsorship and development-support information.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: debpalash

Merge Risk: ⚪ Minimal · up to 45fa2

No actionable issue is established in the documentation update, so it is mergeable subject to normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 45fa2

The change affects 1 system.

Changed systems: README_CN.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — README_CN.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README_CN.md: The header replaces the brief local-build tagline and local-AI description with a Trendshift badge, expanded capability and language claims, a website link, and CI, release, and license badges.
  • observed — Modified behavior in README_CN.md: The former “create with VoiceStudio” feature list is replaced by a workflow table covering creation, production, and integrations; the overview also identifies OmniVoice as the default engine and links to the feature and engine catalog. A collapsible workspace gallery is introduced.
  • observed — Modified behavior in README_CN.md: The gallery updates the voice-design and model image descriptions and adds a desktop-workspace image within the collapsible section.
  • observed — Modified behavior in README_CN.md: The getting-started section adds macOS/Linux install-script commands for the latest release, a specified version, a build from main, and uninstalling while retaining data. It documents download and build prerequisites, settings/project/model retention, and that older versions must include Electron and will not fall back to archived Tauri builds.
🚥 Pre-merge checks | ✅ 8 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title accurately describes the README change, but it does not use conventional-commit syntax with a scope, such as docs(readme): .... Rename the PR using a conventional-commit title with a scope, for example docs(readme): refresh Chinese README for Electron launch. Keep or add a valid issue reference in the title or description, and do not add a version bump unless requ…
✅ Passed checks (8 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required summary, changes, type, testing, checklist, and release-cadence sections. It clearly identifies this as a documentation-only change and explains why version and r…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cross-Platform Default Parity ✅ Passed The pull request changes only README_CN.md. The diff contains documentation text, links, screenshots, and shell instructions; it changes no runtime, configuration, build, or platform-default code. The…
I18n Completeness (21 Locales) ✅ Passed PASS — the authoritative PR diff changes only README_CN.md. It adds no frontend code, no t('...') keys, and no frontend user-facing strings that could bypass i18n.
Local-First Guarantee ✅ Passed PASS — The PR changes only README_CN.md; it adds no runtime, dependency, or telemetry code. The new documentation marks remote workers and usage analytics as optional, and the existing analytics imple…
Backward Compatibility ✅ Passed The PR changes only README_CN.md; it does not change runtime code, omnivoice_data, database schema, migrations, installers, engines, or model storage. The referenced unchanged installer documentat…
Full details: Title check

Resolution

Rename the PR using a conventional-commit title with a scope, for example docs(readme): refresh Chinese README for Electron launch. Keep or add a valid issue reference in the title or description, and do not add a version bump unless requested by the owner.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

debpalash added a commit that referenced this pull request Sep 29, 2026
Consolidate community engine, workflow, dictation, and setup fixes with the Electron composer, sidebar, and voice UI.

Fix review findings in engine residency, remote exports, backup cleanup, bounded compressed-audio decoding, and reference preprocessing. Preserve contributor credits in CHANGELOG.md and leave the app version unchanged.

Supersedes #2325, #2338, #2368, #2377, #2379, #2380, #2383, #2384, #2387, #2390, #2391, #2392, #2393, #2395, #2400, #2401, #2402, #2409, #2410, and #2412.
@debpalash

Copy link
Copy Markdown
Owner

Implemented and merged through #2419. Contributor credit is preserved in CHANGELOG.md.

@debpalash debpalash closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants