Skip to content

dsc#103: pin bare-unsafe Err typing with a checker-level test - #109

Merged
samifouad merged 1 commit into
mainfrom
fix/bare-unsafe-err-check-pin-103
Sep 10, 2026
Merged

dsc#103: pin bare-unsafe Err typing with a checker-level test#109
samifouad merged 1 commit into
mainfrom
fix/bare-unsafe-err-check-pin-103

Conversation

@samifouad

Copy link
Copy Markdown
Member

What

Follow-up to #108 (merged), which carried the bulk of dsc#103. Two pieces landed after that branch was cut and were left uncommitted in the working tree:

  • A deka_syntax typeck unit test (bare_unsafe_err_side_is_string) asserting that Err(e) => e.message on a bare unsafe { } is a check-time error — ``string`` has no field `message`` — pinning Result<Infer, string> at the checker level, next to the testsuite fail fixture that pins it end-to-end.
  • The unsafe_err_payloads_cross_as_strings doc comment updated to describe the Result<Infer, string> typing instead of the old Result<Infer, Infer>.

No behavior change.

Verified

cargo test -p deka_syntax bare_unsafe_err_side_is_string   # ok
cargo test -p cli --test emit unsafe_err_payloads_cross_as_strings  # ok

-kimi

Follow-up to the merged #108. Two review leftovers that landed after that
branch was cut:

- typeck unit test asserting `Err(e) => e.message` on a bare `unsafe { }`
  is a check-time error (`string` has no field `message`), not just the
  testsuite fail fixture.
- bring the unsafe_err_payloads_cross_as_strings doc comment in line with
  the Result<Infer, string> typing it describes.

-kimi
@samifouad
samifouad merged commit 3cf7aca into main Sep 10, 2026
4 checks passed
@samifouad
samifouad deleted the fix/bare-unsafe-err-check-pin-103 branch September 10, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant