dsc#103: pin bare-unsafe Err typing with a checker-level test - #109
Merged
Conversation
Follow-up to the merged #108. Two review leftovers that landed after that branch was cut: - typeck unit test asserting `Err(e) => e.message` on a bare `unsafe { }` is a check-time error (`string` has no field `message`), not just the testsuite fail fixture. - bring the unsafe_err_payloads_cross_as_strings doc comment in line with the Result<Infer, string> typing it describes. -kimi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #108 (merged), which carried the bulk of dsc#103. Two pieces landed after that branch was cut and were left uncommitted in the working tree:
deka_syntaxtypeck unit test (bare_unsafe_err_side_is_string) asserting thatErr(e) => e.messageon a bareunsafe { }is a check-time error — ``string`` has no field `message`` — pinningResult<Infer, string>at the checker level, next to the testsuite fail fixture that pins it end-to-end.unsafe_err_payloads_cross_as_stringsdoc comment updated to describe theResult<Infer, string>typing instead of the oldResult<Infer, Infer>.No behavior change.
Verified
-kimi