Fix coverage report glob pattern and update npm devDependencies - #123
Merged
Conversation
coverlet.MTP (required alongside xunit.v3 4.0.0 under the Microsoft.Testing.Platform 'dotnet test' mode) names its opencover output files 'coverage.opencover.<session-id>.xml'. The previous scanner glob '**/*.opencover.xml' only matches filenames literally ending in 'opencover.xml', so it silently found zero coverage reports despite tests passing. Updated the glob to '**/coverage.opencover.*.xml' to match coverlet.MTP's actual output naming. Verified locally: 'dotnet test --coverlet --coverlet-output-format opencover' produces coverage.opencover.<session-id>.xml files that match the new glob, and all tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Updated devDependencies in package.json to their latest published versions to address Dependabot-flagged vulnerabilities and keep tooling current: - @mermaid-js/mermaid-cli 11.12.0 -> 11.16.0 - cspell 9.7.0 -> 10.1.1 - markdownlint-cli2 0.21.0 -> 0.23.2 mermaid-filter was already at the latest version (1.4.7). Only direct dependencies were bumped; package-lock.json is gitignored in this repo so there is no lockfile diff to manage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI/dev-tooling configuration by adjusting the SonarCloud OpenCover coverage report path pattern in the build workflow and bumping several Node-based devDependencies used for documentation/lint tooling.
Changes:
- Bumped
@mermaid-js/mermaid-cli,cspell, andmarkdownlint-cli2versions inpackage.json. - Updated SonarScanner OpenCover report glob in
.github/workflows/build.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Upgrades devDependencies for mermaid rendering, spell checking, and markdown linting. |
| .github/workflows/build.yaml | Adjusts SonarCloud OpenCover report path pattern used during CI analysis. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes small but important updates to the build configuration and development dependencies. The main changes are an update to the SonarCloud OpenCover report path pattern and upgrades to several dev dependencies in
package.json.Build and CI configuration:
.github/workflows/build.yamlto match**/coverage.opencover.*.xml, making the report collection more robust for multi-project setups.Development dependencies:
@mermaid-js/mermaid-clito11.16.0,cspellto10.1.1, andmarkdownlint-cli2to0.23.2inpackage.jsonfor improved features and bug fixes.