feat(access-key): create read-only and app-scoped keys - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpctl access-key addcould only create keys with full access to every app. Adds two flags:-scope readcreates a key that can only make GET requests. Default stays full.--app <name>limits the key to one app; repeat for several. Omit for all apps.Examples:
dpctl access-key add "MyApp CI" --app MyApp-iOS --app MyApp-Androiddpctl access-key add "Metrics bot" --scope readThe API scopes by app id but people type app names, so names are resolved first and a bad one fails before the key is minted rather than after.
access-key lsgains a Scope column reading full access, all apps or read only, MyApp-iOS.Neither field is sent when the flag is absent, so a key created without the new flags is byte-identical to before.