Skip to content

fix(dex): restrict GitHub connector to maintainers #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devantler wants to merge 3 commits into from
Closed

fix(dex): restrict GitHub connector to maintainers #2708

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6f2e21
fix(dex): restrict github connector to maintainers
devantler Jul 18, 2026
451ef69
Merge branch 'main' into codex/propose-fix-for-actual-budget-oidc-vul…
devantler Jul 19, 2026
fff84ba
Merge branch 'main' into codex/propose-fix-for-actual-budget-oidc-vul…
devantler Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions k8s/bases/infrastructure/controllers/dex/helm-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,9 @@ spec:
useLoginAsID: false
orgs:
- name: devantler-tech
# Actual Budget authenticates directly against Dex, without
# oauth2-proxy's allowed_groups layer. Restrict the shared
# GitHub connector to the same maintainer team so native OIDC
# apps cannot be accessed by every organization member.
teams:

@devantler devantler Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

[P1] Keep the team gate at the Actual-specific boundary

This teams entry is on the only GitHub connector, so it affects every Dex client, not just Actual Budget. Current main registers oauth2-proxy, Headlamp, Vault, KSail, Crossview, and kubectl on this connector; docs/oidc-kubectl.md explicitly permits any devantler-tech organization member, and the current Crossview configuration intentionally treats any organization member as its effective gate. Merging this therefore silently revokes those documented access paths for every non-maintainers member. Enforce the restriction at an Actual-specific boundary, such as a dedicated client or proxy with an app-scoped gate, and add positive and negative authentication coverage proving the other Dex consumers retain their current organization-member policy.

- maintainers
Loading