Skip to content

chore: drive release-please version bumps from inline markers #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alukach merged 4 commits into from
Sep 28, 2026
Merged

chore: drive release-please version bumps from inline markers #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26d2fe1
ci: keep Cargo.lock in step with releases and gate CI on --locked
alukach Sep 25, 2026
abe8333
chore: drive release-please version bumps from inline markers
alukach Sep 25, 2026
379fee2
chore: reset internal version pins left at the simulated 0.7.3
alukach Sep 25, 2026
5c49c45
Merge branch 'main' into chore/release-please-version-markers
alukach Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ make test-integration

`Cargo.lock` is committed and CI runs `cargo check --locked`, so commit lockfile changes alongside any dependency change. The release PR bumps the workspace members' entries in `Cargo.lock` itself (see `release-please-config.json`), so a release never leaves the lockfile stale.

When adding a workspace crate, give its `[workspace.dependencies]` entry a `version` pin (cargo requires one to publish a path dependency) and end the line with `# x-release-please-version`, as the existing entries do. That comment is what the release PR keys on; without it the new crate's pin is left behind at the old version.

## Release Process

### Publishable Crates
Expand Down
16 changes: 8 additions & 8 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ default-members = [
resolver = "2"

[workspace.package]
version = "0.7.2"
version = "0.7.2" # x-release-please-version
edition = "2021"
license = "MIT"

Expand Down Expand Up @@ -105,10 +105,10 @@ console_error_panic_hook = "0.1.7"
lambda_http = "0.13"

# Internal crates
multistore = { path = "crates/core", version = "0.7.2" }
multistore-static-config = { path = "crates/static-config", version = "0.7.2" }
multistore-sts = { path = "crates/sts", version = "0.7.2" }
multistore-metering = { path = "crates/metering", version = "0.7.2" }
multistore-cf-workers = { path = "crates/cf-workers", version = "0.7.2" }
multistore-oidc-provider = { path = "crates/oidc-provider", version = "0.7.2" }
multistore-path-mapping = { path = "crates/path-mapping", version = "0.7.2" }
multistore = { path = "crates/core", version = "0.7.2" } # x-release-please-version
multistore-static-config = { path = "crates/static-config", version = "0.7.2" } # x-release-please-version
multistore-sts = { path = "crates/sts", version = "0.7.2" } # x-release-please-version
multistore-metering = { path = "crates/metering", version = "0.7.2" } # x-release-please-version
multistore-cf-workers = { path = "crates/cf-workers", version = "0.7.2" } # x-release-please-version
multistore-oidc-provider = { path = "crates/oidc-provider", version = "0.7.2" } # x-release-please-version
multistore-path-mapping = { path = "crates/path-mapping", version = "0.7.2" } # x-release-please-version
40 changes: 2 additions & 38 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,44 +6,8 @@
"include-component-in-tag": false,
"extra-files": [
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.package.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-static-config.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-sts.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-metering.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-cf-workers.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-oidc-provider.version"
},
{
"type": "toml",
"path": "Cargo.toml",
"jsonpath": "$.workspace.dependencies.multistore-path-mapping.version"
"type": "generic",
"path": "Cargo.toml"
},
{
"type": "toml",
Expand Down
Loading