fix(docker): remove unused ci-final stage breaking container builds - #65
Merged
Merged
Conversation
The ci-final stage was added as the last Dockerfile stage but its COPY publish/ . requires a pre-published directory absent from the build context. Plain docker build (GitHub + Azure DevOps) defaults to the last stage and fails. GitLab explicitly targets --target final and is unaffected. Nothing references ci-final. Fixes #64
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores container builds across all three CI providers by removing the broken
ci-finalDockerfile stage introduced in 601ebff.Closes #64
Root cause
The
added third provider: GitLabpush appendedci-finalas the last stage ofsrc/webapp01/Dockerfile. ItsCOPY publish/ .needs a pre-publishedpublish/dir absent from the build context. Plaindocker build/docker/build-push-action(no--target) default to the last stage and fail with\/publish\: not found.Failing workflows fixed
Tri-provider safety
az acr build ... --target finalexplicitly; unaffected.docker buildreturns to defaultfinal; fixed.final; fixed.No pipeline anywhere references
ci-final.