fix(ansible): install openssh-client and fix ansible-lint config loading - #59
Merged
matthew-on-git merged 1 commit intoJul 30, 2026
Merged
Conversation
- Install openssh-client in the container (required by ansible-core's default SSH transport) so ansible-playbook can reach remote hosts without manual before_script workarounds (closes #57) - Replace ANSIBLE_ROLES_PATH workaround with run_per_project ansible so ansible-lint runs from each detected project root, letting Ansible load ansible.cfg naturally (closes #58) - Update README included tools table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issue #57 — Missing SSH client prevents Ansible from reaching remote hosts
scripts/install-ansible.sh: Adds idempotent installation ofopenssh-clientvia apt-get. The image shipsansible-corebut had no SSH client, soansible-playbookcould not connect to any remote host via the default SSH transport. Users had to install it themselves inbefore_script.Issue #58 —
ansible.cfginproject_dirnever loaded byansible-lintMakefile(_linttarget): Replaces theANSIBLE_ROLES_PATHworkaround (which only handledroles_path) withrun_per_project ansible "ansible-lint". This uses the existing project discovery system to find directories containingansible.cfgand runsansible-lintfrom each detected root, so Ansible's cwd-based config resolution loadsansible.cfgnaturally — includingroles_path,inventory, and all other settings. Falls back to the workspace root if noansible.cfgis found in subdirectories.README.md: Updated the Included Tools table to listopenssh-clientunder Ansible.Verification
make checkpasses (lint, format, scan, docs)openssh-clientinstalled during the Ansible stage