Skip to content

Create column titles for all views - #269

Merged
djdiskmachine merged 4 commits into
djdiskmachine:masterfrom
brunodles:createColumnTitlesForViews
Sep 3, 2026
Merged

Create column titles for all views#269
djdiskmachine merged 4 commits into
djdiskmachine:masterfrom
brunodles:createColumnTitlesForViews

Conversation

@brunodles

Copy link
Copy Markdown

Description

This PR will add column titles for most of the screens.
The titles are just indicating what is presented on the column.
A new configuration property was also included to change the color of the column.

Screenshot From 2026-08-16 15-42-57 Screenshot From 2026-08-16 15-43-00 Screenshot From 2026-08-16 15-43-03 Screenshot From 2026-08-16 15-43-08 Screenshot From 2026-08-16 15-43-11 Screenshot From 2026-08-16 15-44-08

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests procedure by which you verified your changes.
Provide instructions on how to reproduce.

Test Configuration: x64

  • Hardware: Intel PC
  • Test steps:
    1. create a project
    2. verify that the song view have number on the top of each column
    3. create a chain
    4. navigate into the change
    5. verify that the chain have column titles
    6. create a phrase
    7. navigate into the phrase
    8. verify that the phrase view have column titles
    9. navigate to the groovy view
    10. verify that the groovy view have column titles
    11. navigate into the table view
    12. verify that the table view have column titles
    13. navigate to the mixer view
    14. verify that the mixer view have colors matching the other column titles

Checklist:

  • I have performed a self-review of my code
  • I have commented particularly in hard-to-understand areas
  • I have updated CHANGELOG
  • I have updated docs/wiki/What-is-LittlePiggyTracker.md reflecting my changes
  • I have version bumped in sources/Application/Model/Project.h
  • My changes generate no new warnings (build without your change then apply your change to check this)

Introduce a bit of description on the head of each column, acting as
titles, indication or description of what is added there.
@djdiskmachine

Copy link
Copy Markdown
Owner

Hey!
Thanks so much for making this change. There's a lot of good stuff in here, but there's also some things that strike me as dissonant.
When making the MixerView I tried out having column numbers but finally decided against it. I think I'd prefer to have the same number of chars for each item in a view where applicable.. If that makes sense?
so for SongView / MixerView:
01 02 .. 08 (will this be confusing as it looks too much like the row below?) 🤔

ChainView:
Ph Ts
or maybe
Phr Tsp <- requires another space

Phraseview:
Note Ins Cmd1 Cmd2

Lmk if you think any of this is reasonable!

@brunodles

Copy link
Copy Markdown
Author

Updated to use two chars.
The result.
Screenshot From 2026-08-23 23-50-40
Screenshot From 2026-08-23 23-50-45
Screenshot From 2026-08-23 23-50-48

@djdiskmachine

Copy link
Copy Markdown
Owner

Hey sorry for being so slow to, I have a new job and limited extra real estate in my head for code right now.
This commit looks really good. My only nitpick is that I feel that the default color schema might be too similar to the color used for the FE color.
I might make a complementary commit for this at some point and let this throug now so we can get it into peoples hands. Cheers!

@djdiskmachine
djdiskmachine merged commit a487ee0 into djdiskmachine:master Sep 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants