Skip to content

Outputs of the Direct Grammar in the README are misleading #36

Description

@yetanotherion

Executing the Direct Grammar on a worksheet

import parseback.compat.cats._
import cats.Eval

implicit val W = Whitespace("""\s+"""r)

lazy val expr: Parser[Int] = (
  expr ~ "+" ~ term ^^ { (_, e, _, t) => e + t }
    | expr ~ "-" ~ term ^^ { (_, e, _, t) => e - t }
    | term
  )

lazy val term: Parser[Int] = (
  term ~ "*" ~ factor ^^ { (_, e, _, f) => e * f }
    | term ~ "/" ~ factor ^^ { (_, e, _, f) => e / f }
    | factor
  )

lazy val factor: Parser[Int] = (
  "(" ~> expr <~ ")"
    | "-" ~ expr  ^^ { (_, _, e) => -e }
    | """\d+""".r ^^ { (_, str) => str.toInt }
  )

among others, one input of the README

expr(LineStream[Eval]("1 + 2")).value

does not parse and generates

res0: parseback.util.EitherSyntax.\/[List[parseback.ParseError],parseback.util.Catenable[Int]] = Left(List(UnexpectedCharacter(Line(1 + 2,0,0),Set(\s+))))

instead. The expression producing the expected output requires whitespaces at the beginning and the end.

expr(LineStream[Eval](" 1 + 2 ")).value
res1: parseback.util.EitherSyntax.\/[List[parseback.ParseError],parseback.util.Catenable[Int]] = Right(Single(3))

(I suspect this may be due to
Note that parseback's whitespace handling is currently extremely naive. The only whitespace regular expressions which will behave appropriately are of the form .+, where . is "any single character class". Thus, \s+ is valid, as is [ \t]+, but //[^\n]*|\s+ is not. We hope to lift this restriction soon, but it requires some work on the algorithm.
isn't it?)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions