Feat/39 bookmarks - #49
Merged
Merged
Conversation
…property on bookmark button
…marking an article
…rticleId is hardcoded in SavedArticlesSection
…ing in bookmarking article page
…eat/39-bookmarks
…mistic updates to prevent UI crashes, and added hardcoded articleIds in RecentlyViewedSection
xandreiAThome
requested changes
May 24, 2026
xandreiAThome
requested changes
May 24, 2026
…rticle unathorized now opens login modal
…ly seen by authenticated users, and does not appear in bookmarks page
…eat/39-bookmarks
…edArticleItem, and reused ArticleItem for BookmarkedList
xandreiAThome
requested changes
May 24, 2026
…icles and removed redundant handleToggleBookmark in ArticleHeader
xandreiAThome
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issues
closes #39
Type of Change
Notes for Reviewers
Hardcoded articleIds in SavedArticlesSection.tsx and RecentlyViewedSection.tsx in the related sidebar (might deal with this in #40 ) and in ArticleHeader.tsx since there's no route like /article/[id] or /article/[slug]