This repository was archived by the owner on Jun 16, 2026. It is now read-only.
Add requests monitoring - #151
Merged
Merged
Conversation
Bumped for docker/model-runner@5449fc9. See all changes in docker/model-runner@5341c9f...38bb017. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
xenoscopic
approved these changes
Sep 12, 2025
xenoscopic
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I still agree with @ilopezluna that it'd be worth combining the two endpoints and differentiating on Accept if in docker/model-runner#157 if it's not too much work.
Differentiate regular and streaming based on the Accept Header. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Contributor
Author
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
…indows/arm64 Signed-off-by: Dorin Geman <dorin.geman@docker.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new requests command to the Docker Model CLI that fetches requests and responses from the Docker Model Runner, enabling monitoring of model inference activities. The implementation includes both one-shot and streaming modes with optional model filtering.
- Adds
docker model requestscommand with streaming and filtering capabilities - Updates dependencies to include model-runner support for request monitoring
- Provides comprehensive documentation and CLI completion for the new feature
Reviewed Changes
Copilot reviewed 8 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates model-runner and model-distribution dependencies to support request monitoring |
| docs/reference/model_requests.md | Adds documentation for the new requests command |
| docs/reference/model.md | Updates parent command documentation to include requests subcommand |
| docs/reference/docker_model_requests.yaml | Defines CLI specification for requests command options |
| docs/reference/docker_model.yaml | Updates parent command specification to include requests |
| desktop/desktop.go | Implements HTTP client method for fetching requests with streaming support |
| commands/root.go | Registers the new requests command with the CLI |
| commands/requests.go | Implements the requests command with streaming, filtering, and completion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add requests monitoring. It uses docker/model-runner#157.
In docker/model-runner#157:
Here:
Note the completion added for
--model.TODO: Add
--format.