Skip to content

Bump llamacpp to b9859#995

Merged
ericcurtin merged 1 commit into
docker:mainfrom
krissetto:bump-llamacpp-b9859
Jul 3, 2026
Merged

Bump llamacpp to b9859#995
ericcurtin merged 1 commit into
docker:mainfrom
krissetto:bump-llamacpp-b9859

Conversation

@krissetto

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LLAMA_SERVER_VERSION to b9859 in the .versions file and the Dockerfile, and bumps the llama.cpp vendor subproject commit to 4fc4ec5541b243957ae5099edb67372f8f3b550e. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="Dockerfile" line_range="4-6" />
<code_context>

 ARG GO_VERSION=1.25
-ARG LLAMA_SERVER_VERSION=b9592
+ARG LLAMA_SERVER_VERSION=b9859
 ARG LLAMA_SERVER_VARIANT=cpu
-ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9592
+ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9859

 ARG VERSION=dev
</code_context>
<issue_to_address>
**suggestion:** Avoid duplicating the llama.cpp version string to reduce risk of future drift.

LLAMA_SERVER_VERSION and LLAMA_UPSTREAM_IMAGE both embed `b9859`. Please derive LLAMA_UPSTREAM_IMAGE from LLAMA_SERVER_VERSION (e.g., via build arg or build-time substitution) so version bumps only require a single update and can’t drift out of sync.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread Dockerfile
Comment on lines +4 to +6
ARG LLAMA_SERVER_VERSION=b9859
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9592
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9859

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid duplicating the llama.cpp version string to reduce risk of future drift.

LLAMA_SERVER_VERSION and LLAMA_UPSTREAM_IMAGE both embed b9859. Please derive LLAMA_UPSTREAM_IMAGE from LLAMA_SERVER_VERSION (e.g., via build arg or build-time substitution) so version bumps only require a single update and can’t drift out of sync.

@ericcurtin ericcurtin merged commit 2b405d3 into docker:main Jul 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants