expose all attempted execution migrations - #1194
Draft
goetas wants to merge 1 commit into
Draft
Conversation
goetas
commented
Aug 22, 2021
goetas
commented
Member
| Q | A |
|---|---|
| Type | feature |
| BC Break | no |
| Fixed issues | - |
goetas
commented
Aug 22, 2021
| * Returns all the for which there was an execution attempt | ||
| * Includes skipped, errored executed migrations. | ||
| */ | ||
| public function getAllExecutedMigrations(): ExecutedMigrationsList; |
Member
Author
There was a problem hiding this comment.
what would be here the best way to add such functionality to this interface in a backward compatible way?
Member
There was a problem hiding this comment.
Usually something like
class Foo implements MetadataStorage, AllExecutedMigrationsInterfaceThingy
but I assume you're looking for something different?
| Version $version, | ||
| ?DateTimeImmutable $executedAt = null, | ||
| ?float $executionTime = null, | ||
| ?string $reason |
Member
There was a problem hiding this comment.
Why did you decide not to use
Suggested change
| ?string $reason | |
| ?string $reason = null |
?
| public function getExecutedMigrations(): ExecutedMigrationsList; | ||
|
|
||
| /** | ||
| * Returns all the for which there was an execution attempt |
Member
There was a problem hiding this comment.
Suggested change
| * Returns all the for which there was an execution attempt | |
| * Returns all the migrations for which there was an execution attempt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.